search

miekg / dns

DNS library in Go
https://miek.nl/2014/august/16/go-dns-package
BSD 3-Clause "New" or "Revised" License
8.07k stars 1.14k forks source link

Duplicate DNS rCode? #1523

Closed melroy89 closed 11 months ago

melroy89 commented 11 months ago

When I look at: https://github.com/miekg/dns/blob/836bea2f8dffa00b74af2d505c04e1cde3a9739b/types.go#L138C2-L138C13

I see two times code 16 being used. 16 is used for both BADSIG and BADVERS. Is that on purpose, or is this some kind of typo?

Sorry for asking.

gibson042 commented 11 months ago

It's unfortunate but accurate, cf. https://www.rfc-editor.org/rfc/rfc6895#section-2.3

melroy89 commented 11 months ago

Someone from IETF was sleeping I think..