search

miekg / learninggo

Learning Go Book in mmark
https://miek.nl/go
Other
539 stars 111 forks source link

Hyperlinks to headers fixed; font changes #48

Closed kartikynwa closed 6 years ago

kartikynwa commented 6 years ago
miekg commented 6 years ago

Can do the css changes - but they need to come in another PR.

kartikynwa commented 6 years ago

Yeah you're right. I swear to god though when I was reading on my laptop I didn't see the links. Now I open it on my phone and everything is okay. Spooky stuff right there.

Sorry for wasting your time.

On 15-Dec-2017 21:34, "Miek Gieben" notifications@github.com wrote:

@miekg commented on this pull request.

In basics.md https://github.com/miekg/learninggo/pull/48#discussion_r157236208:

@@ -22,7 +22,7 @@ a standalone executable.

import "fmt" says we need fmt in addition to main <2>. A package other than main is commonly called a library, a familiar concept in many programming -languages (see (#packages)). The line ends with a comment that begins with //. +languages (see Packages). The line ends with a comment that begins with //.

This should not be needed, (#packages) is sufficient. And the the html is work, for mmarks RFC output this should also be enough

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miekg/learninggo/pull/48#pullrequestreview-83850707, or mute the thread https://github.com/notifications/unsubscribe-auth/AHe4rEKzbj6IA4EG46ftv56mdVgYbcEgks5tAph3gaJpZM4RCPqO .

miekg commented 6 years ago

[ Quoting notifications@github.com in "Re: [miekg/learninggo] Hyperlinks t..." ]

Yeah you're right. I swear to god though when I was reading on my laptop I didn't see the links. Now I open it on my phone and everything is okay. Spooky stuff right there.

Sorry for wasting your time.

Np, is javascript inserting these, so.....

kartikynwa commented 6 years ago

That explains it. It's uMatrix's fault then. Good job detective.

On 15-Dec-2017 9:58 PM, "Miek Gieben" notifications@github.com wrote:

[ Quoting notifications@github.com in "Re: [miekg/learninggo] Hyperlinks t..." ]

Yeah you're right. I swear to god though when I was reading on my laptop I didn't see the links. Now I open it on my phone and everything is okay. Spooky stuff right there.

Sorry for wasting your time.

Np, is javascript inserting these, so.....

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miekg/learninggo/pull/48#issuecomment-352049281, or mute the thread https://github.com/notifications/unsubscribe-auth/AHe4rCmH3atjvDbeye4ad-Gy3TO2J0aoks5tAp5JgaJpZM4RCPqO .