search

miekg / pgo

container gitops in a simple way
GNU General Public License v3.0
11 stars 1 forks source link

service names need to be unique as well #42

Closed miekg closed 1 year ago

miekg commented 1 year ago

As all services share the network, they need to have unique names as well?

Can we sidestep this? Do we need to test this?

miekg commented 1 year ago

and we, indeed, don't care about ports numbers, we care about the uniqueness of the 'service' names, which means we need to prefix them, so each service has a prefix (the servicename?) that needs to be used in the docker-compose file, which is something we can check, at least that's what we can check when we generate the caddy import file, i.e. extract only services with that specific name.

miekg commented 1 year ago

the latter has been implemented, so this can be closed.