miekg / pgo

container gitops in a simple way
GNU General Public License v3.0
11 stars 1 forks source link

server reboots/pgod restarts #8

Closed miekg closed 1 year ago

miekg commented 1 year ago

Are we handling that OK? Need tests and docs and maybe some code changes.

miekg commented 1 year ago

yep, a restart means you loose the container.

26c211f57f3d  docker.io/library/busybox:latest      /bin/busybox http...  37 hours ago    Up 37 hours ago    0.0.0.0:42651->8080/tcp   pgo-3809413984_frontend_1
4fe30f61c4db  docker.io/library/busybox:latest      /bin/busybox http...  37 hours ago    Up 37 hours ago    0.0.0.0:40475->8080/tcp   pgo-609353550_frontend_1
cd6751ace8b6  docker.io/library/busybox:latest      /bin/busybox http...  59 minutes ago  Up 59 minutes ago  0.0.0.0:42023->8080/tcp   pgo-1265672294_frontend_1
61380c3c0cbe  docker.io/library/busybox:latest      /bin/busybox http...  53 minutes ago  Up 53 minutes ago  0.0.0.0:36391->8080/tcp   pgo-3493677287_frontend_1
miekg commented 1 year ago

each started container needs to have a more static name so at least you can down and up previously started containers

miekg commented 1 year ago

also need to add a --publish, -p=[[ip:][hostPort]:]containerPort[/protocol] to give it the allowed ports.

And we need to make the git clone be in a deterministic location and survive machine reboots.

miekg commented 1 year ago

so I think we need a fixed place to check out the git repo, this should fix being able to survive restarts.

the only issue is changing branches and how to handle that.

miekg commented 1 year ago

think #14 should fix this. Having a fix dir on disk should make the naming of containers stay the same

miekg commented 1 year ago

tentatively closing for now