search

miekg / pkcs11

pkcs11 wrapper for Go
BSD 3-Clause "New" or "Revised" License
375 stars 133 forks source link

const_generate: hardcode CK_TRUE/CK_FALSE to golang bool values #176

Closed stlaz closed 10 months ago

stlaz commented 10 months ago

The PKCS11 constants are most useful when creating attributes with NewAttribute() in all kinds of different PKCS11 calls. The function is using generic type handling to decide attribute length.

The CK_TRUE/CK_FALSE constants should evaluate to direct Golang bool values in order for these to be handled properly by the NewAttribute() calls, which interprets bool values as []byte{0}, []byte{1} for false, true respectively. If these stay integers, NewAttribtue() considers them 8-byte long byte slices.

Some PKCS11 module implementations actually validate constant-length arguments size. https://github.com/opendnssec/SoftHSMv2/ is an example of a commonly used PKCS11-testing module that does that. Without this change, the module fails to perform certain actions as it errors out on unexpected attribute size.

miekg commented 10 months ago

thanks, slightly concerned about backwards compatibility, but seems useful enough to merge.