Request for opacity bar for font color in epub and live preview of it

mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**

MIT License

223 stars 10 forks source link

Request for opacity bar for font color in epub and live preview of it #138

Closed zeoint closed 1 year ago

zeoint commented 1 year ago

Description of the new feature / enhancement

Sometimes the white font color is too bright to read with black / grey background. So an opacity bar to adjust the font opactiy and a live preview of it, so I can save at the color, opacity I like. It doesn't need to save it automatically, only save it by clicking on the save and apply button.

Scenario when this would be used?

To set the font color, opacity in epub.

Supporting information

By live preview, I want to see the change happening to the epub font, so that I could choose a perfect font color, opacity settings while reading epub's. Just like how it is done for theme maker. It shows live preview.

Suppose in the app theme maker, while changing the background it shows live preview and if save is not clicked it is not saved. The same way for epub reader settings as it is now, only an opacity bar for font color and live preview is need to be added.

zeoint commented 1 year ago

A general question, why does the theme maker in app settings feel hard when changin colors compared to the theme system in epub reader settings?

Is it a bug in the app theme system?

mienaiyami commented 1 year ago

why does the theme maker in app settings feel hard when changin colors

as you can see, they are reflected in real time while in case of reader settings you need to click save to apply any changes in color. So live preview is cpu intensive, and more so in reader settings so i had to make a save button for it.

zeoint commented 1 year ago

So live preview is cpu intensive, and more so in reader settings so i had to make a save button for it.

Cool. How much increase in cpu usage compared to now?

mienaiyami commented 1 year ago

UI will stop working for few seconds (over 10s easily).

zeoint commented 1 year ago

UI will stop working for few seconds (over 10s easily).

Oh my gosh, Should I close this issue then? or is there a win-win situation.

By that, I meant live preview, 2 - 5% more present cpu usage, smooth theme system.

mienaiyami commented 1 year ago

I can add opacity though.

zeoint commented 1 year ago

Okay. Thanks.

omodia commented 1 year ago

UI will stop working for few seconds (over 10s easily).

Oh my gosh, Should I close this issue then? or is there a win-win situation. By that, I meant live preview, 2 - 5% more present cpu usage, smooth theme system.

v2.8.0 supports it. But there will not be epub support as it is an older version.

mienaiyami commented 1 year ago

v2.8.0 supports it.

what are you referring to?

omodia commented 1 year ago

v2.8.0 supports it.

what are you referring to?

I was talking about the smooth app theme system with live preview and normal cpu usage with no screen freezing. Since that was what the person asked.

zeoint commented 1 year ago

v2.8.0 supports it. But there will not be epub support as it is an older version.

Yes, it works. So I am confused as to why it replaced with the hard theme system?

omodia commented 1 year ago

Yes, it works. So I am confused as to why it replaced with the hard theme system?

Reference #82 .

zeoint commented 1 year ago

Reference #82 . @omodia

Both systems show live preview and both need to be saved for the colors to apply.
The old theme system user 10 - 15 percent more CPU usage than the new theme system when the cursor is dragged slowly.
The old theme system uses 20 - 25 percent more CPU usage if the cursor is dragged very fast.

The old theme system was smooth therefore causing the change to happen quickly, hence uses more CPU resources. I personally think the new theme system is better, because it uses considerably less CPU resources than the old theme system.

You just need to drag the cursor a bit slower for this new theme system to work quickly when you want to change the theme. Also, the benefit is you will have lower cpu usage and it's not like themes are changed everyday.

zeoint commented 1 year ago

UI will stop working for few seconds (over 10s easily).

I thought of a possible solution to it. So, when an epub file is opened,

While changing the font color, opacity, rather than applying the live preview to appear for the entire epub file,
Only make the live preview to change / appear for the current viewing chapter.
And after clicking on the 'save and apply button', only then make the change happen to the entire epub file.
This would solve the issue giving a win-win situation, I think.

zeoint commented 1 year ago

And after clicking on the 'save and apply button', only then make the change happen to the entire epub file.

Clicking outside the epub reader settings or closing the reader settings without clicking on the 'save and apply button' will dismiss the live preview. This can be observed while changing themes.

As can be observed in the below video, the live preview happened, but I clicked outside the app settings / closed the app settings, thus dismissing the live preview.

zeoint commented 1 year ago

Oops, the above method I said might only be possible if the 'Load and show one chapter at a time (from TOC)' is the only way to read epub, otherwise the live preview will happen for the entire epub file causing the epub to freeze easily for 10 seconds like you said.

mienaiyami commented 1 year ago

No, even if its just one chapter it will still freeze.

zeoint commented 1 year ago

No, even if its just one chapter it will still freeze.

Cool. Then please ignore the live preview request. Thanks.