search

mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
223 stars 10 forks source link

Improper margin width #170

Closed omodia closed 11 months ago

omodia commented 1 year ago

Setup or portable version of the app?

Portable

Steps to reproduce

This might be related to #169. Found this bug while trying to reproduce #169.

Case - 1

  1. Extract and open the above zip file.
  2. Scroll to page 37.
  3. Enable show gap between rows.
  4. Keep an eye on the right edge of the page.
  5. Disable gap between rows.
  6. Improper margin width can be seen at right edge even when current page and previous page width is 850 px.

Case - 2

  1. Extract and open the above zip file.
  2. Scroll to page 37.
  3. Enable show gap between rows.
  4. Keep an eye on all the four edges of the page.
  5. Improper margin width can be seen even when in free size and also when max page width is enabled in 1:1 option.

✔️ Expected Behavior

To not show any improper margin width for both cases.

❌ Actual Behavior

Shows improper margin width for both cases.

omodia commented 1 year ago

Can be seen time to time when there are high number of pages.

mienaiyami commented 1 year ago

Such things are not something I can fix sadly. It is caused by browser rendering issues. Same goes for #169. I will try to update chromium version next time, may or may not help.

Also in this issue, its possible that rightmost pixels are all black.

omodia commented 1 year ago

Such things are not something I can fix sadly. It is caused by browser rendering issues. Same goes for #169. I will try to update chromium version next time, may or may not help.

I did not come across #169 until a day ago, that too hard to reproduce. It is as you said caused by browser. It is very rare. Okay. No problem.

omodia commented 1 year ago

I will try to update chromium version next time, may or may not help.

I have a doubt. In Yomikiru, are all the images handled and rendered by chromium and electron, be it jpg, png and webp? Or are there any external dependencies to render images?

mienaiyami commented 1 year ago

In Yomikiru, are all the images handled and rendered by chromium and electron, be it jpg, png and webp?

Yes, just chromium.

omodia commented 1 year ago

Very good.

mienaiyami commented 11 months ago

https://github.com/mienaiyami/yomikiru/issues/169#issuecomment-1589317653