search

mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
223 stars 10 forks source link

List Item BG Color Hovered #234

Closed zeoint closed 9 months ago

zeoint commented 9 months ago

Type of installation

Portable (.zip)

Steps to reproduce

List Item BG Color Hovered is not working for drop down list items, instead they are linked to button foucs color.

  1. Open theme maker.
  2. Cycle through any drop down list.
  3. You can see the hover color.
  4. Change ListI tem BG Color Hovered to another color and repeat step 2.
  5. You cannot see the chosen color.
  6. Change button focus color to another color and repeat step 2.
  7. You can see the chosen color on hovering over the items in the drop down list.

✔️ Expected Behavior

Since it is a hover action on drop down list item, it should be linked to List Item BG Color Hovered instead of button focus color.

❌ Actual Behavior

List item BG Color Hovered is not linked to,

zeoint commented 9 months ago

This is just a minor thing, but there is no gap on some words in theme maker. Two words are combined as one.

mienaiyami commented 9 months ago

It is as intended, everything from BG color to focused color is linked to button. Let me know if there is an issue with that. If not, I will be closing it as not planned.

zeoint commented 9 months ago

It is as intended, everything from BG color to focused color is linked to button. ✔️ Expected Behavior Since it is a hover action on drop down list item, it should be linked to List Item BG Color Hovered instead of button focus color.

But the 'list item bg color hovered' is still linked to 'button focus color'.

zeoint commented 9 months ago

I like to link the button focus color to button color. When I hover the list items (be it in themes list or reader settings list), the hover color is not seen because that is linked to button focus color instead of list item bg color hovered. But they are list items so shouldn't they be linked to list item bg color hovered?

mienaiyami commented 9 months ago

Since it is a hover action on drop down list item, it should be linked to List Item BG Color Hovered instead of button focus color.

You see, select options are focused on mouse over, it's not actually hover, kind of. If you click enter of space while mouse is over an option you will notice that, also when you use arrow keys to move selection.

I will be changing BG color of select option to "context menu". If it fits better.

zeoint commented 9 months ago

Cool.

mienaiyami commented 9 months ago

Hover/focused color is now linked to context menu item.