mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
223 stars 10 forks source link

Disable reader side list option (Not hide, but do not execute) #269

Closed xeolod closed 4 months ago

xeolod commented 8 months ago

Description of the new feature / enhancement

I request for the option to disable the reader sidelist for the entire app (Not hide, but do not execute). It might need app restart.

The reader side list is an amazing feature you thought for the app, but when there are many chapters for a comic or txt, single xhtml files, I found when enter / exit full screen it seems slow there, which is normal as there are 1000's of chapters. Let's take martial peak as example, its comic version has 3500+ chapters, novel version is 4900+ chapters and both still ongoing. I think disabling (not executing) the side list via an option would help the app further improve both performance and memory usage.

This feature is a way to future-proof the app. This is my humble request.

Scenario when this would be used?

When a comic or novel has many chapters. If needed then user disable side list, if no need then user no need to disable side list.

Supporting information

I like that you had implemented single txt and xhtml files to be readbale for novels. A great feature no other app has implemented. I read martial peak novel both as epub and single xhtml files. The single xhtml files had improved performance of the app by a far greater margin than reading them as epub.

Sorry for the long words and bad english.

github-actions[bot] commented 8 months ago

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

zeoint commented 8 months ago

Cool idea.

omodia commented 8 months ago

A great way to increase performance and decrease memory consumption of the app if user wishes to. A future-proof idea indeed.

mienaiyami commented 8 months ago

but do not execute

Its not possible for epub, without it you wouldnt be able to change chapters or use internal link. Im aware of the bad performance when changing chapters in epub reader as I too read a lot. I haven't been able to give it much time to improve it. It will require a lot of free time and clear mind to think for better and more performant solutions.

Also, while I recommend just moving read chapters in other folder if they are over 1000, I should have provided an option to not check for "valid folder" (with at least one image). Because now on initial reader open, it read all folders which might be resulting in lag for large chapter count. #272

mienaiyami commented 8 months ago

If you want a temporary solution you can use this in custom css file

.readerSideList:not(#dummy#dummy){
  display:none;
}
xeolod commented 8 months ago

Its not possible for epub, without it you wouldnt be able to change chapters or use internal link.

Then, only do not execute reader side list for possible things like comics, txt, html.

I am not reading epubs in epub format. After u launch the new txt, xhtml system, Im using this systme. (Love the new system) I find that history not recorded in the new system, I wanted to open a issue but find that its there already.

Im aware of the bad performance when changing chapters in epub reader as I too read a lot. I haven't been able to give it much time to improve it. It will require a lot of free time and clear mind to think for better and more performant solutions.

No prob, eventually. I wait.

xeolod commented 4 months ago

I guess the hide list option (only UI) is sufficient as it did improve the performance by large comparred with before its not presant. When its hidden, the performance is on par as for low chapter count. That is y, i think the issue is pointless.

If anything, I request you to optimise the app and reader further, if ti could be done.

mienaiyami commented 4 months ago

I assumed it was also for manga reader. But that will continue at #272 I guess.