search

mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
223 stars 10 forks source link

xhtml / txt / html huge performance issue #310

Open zeoint opened 6 months ago

zeoint commented 6 months ago

Type of installation

Portable (.zip)

Type of reader (if reader related)

epub

Steps to reproduce

  1. Open any xhtml file that has a folder size of > 2000 files. (Tested with >2361 chapters).
  2. Causes a huge performance issue after changing chapter and scrolling down.

Note - The performance loss is mitigated when the side list is hidden. It also increases the scrolling performance.

✔️ Expected Behavior

To not cause performance loss after changing chapter and scrolling down.

❌ Actual Behavior

Causes performance issue after changing chapter and scrolling down.

github-actions[bot] commented 6 months ago

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

mienaiyami commented 6 months ago

I believe epub reader with 2000 chapter will perform a lot better compared to 2000 chapters in manga side-list. As I metioned before, current system for reading txt/xhtml is just modified main reader from epub and sidelist from manga reader.

Manga side-list have function that checks for valid files and folder, and even tho it does not run every time you change chapter, but it does read whole folder content (to check if there is new entry, this function is different from checking valid files/folder). It will probably cause lag.

I suggest you try your epubs in original epub reader with list hidden and check if there is some difference.

zeoint commented 6 months ago

I suggest you try your epubs in original epub reader with list hidden and check if there is some difference.

Tried it, the scrolling feels smooth and the performance issue (Scrolling after chapter change) is not present here.

Manga side-list have function that checks for valid files and folder, and even tho it does not run every time you change chapter, but it does read whole folder content (to check if there is new entry, this function is different from checking valid files/folder). It will probably cause lag.

Looking forward to a solution for this.