Add New in shortcut keys tab and one other misc

[zeoint]

Type of installation

Setup (.exe)

Type of reader (if reader related)

None

Steps to reproduce

Open Yomikiru settings and go to shortcut keys tab.

1. 'Add New' is not a button type and is not linked to button values in theme maker.

• The change in mouse when hovered over a button is not replicated on 'Add New' button.
• And the text color of it is darker than other button colors.
• Example - 'x' button in shortcut keys is linked to all button values in theme maker and change in mouse can be seen on it.

---

2. Assigned shortcut key highlight.

• Disable the highlighting of assigned keys.
• It doesn't do anything, so highlighting is unnecessary.

✔️ Expected Behavior

1. 'Add New' should be a button type and should be linked to the button values in theme maker.
2. Assigned shortcut keys should not be highlighted.

❌ Actual Behavior

1. 'Add New' is not a button type and is not linked to the button values in theme maker.
2. Assigned shortcut keys can be highlighted.

[github-actions[bot]]

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

[mienaiyami]

This is because they are "text inputs" and not buttons, previous version was also "text inputs". Using buttons here is not a great idea because buttons are meant to do some action on click, and there is none here. Here "Add new" is capturing many key clicks so its not a button.

As for the highlight, its not possible to remove it without disabling the whole element's mouse capture.

[zeoint]

Then can the 'Add New' text color be improved? Its linked to text color property, but its shade is darker than other text color related properties.

[mienaiyami]

It is the input placeholder color, which you might also see in search inputs. I will see if there is a better way.

[mienaiyami]

Tried using button for "add new" and replacing it with input on click, but results in many unwanted behaviors. So for now I will keep it same.

[zeoint]

Cool. Thanks for trying.

[zeoint]

Previously because of the dark shade it looked like kind of not allowed to click text. But now in v2.19.1, it looks correct, which is great.

And forget about the button, I thought that it was a button, so I opened the issue in bug. The button is unnecessary.

Thanks for adding the color to it, its what I wanted from it.