search

mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
217 stars 10 forks source link

Open manga folder via context menu #347

Closed yagamiyakumo closed 3 months ago

yagamiyakumo commented 3 months ago

Type of installation

Portable v2.19.1 | 32-bit (.zip)

Type of reader (if reader related)

None

Steps to reproduce

  1. Right click manga folder
  2. Select "Open in Yomikiru"

✔️ Expected Behavior

Load the entire manga folder with all the zip files within

❌ Actual Behavior

Error popup window:

No images found Folder doesn't contain any supported image format.

github-actions[bot] commented 3 months ago

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

yagamiyakumo commented 3 months ago

Going into the folder and open any of the zip files via context menu work correctly as expected behavior (load all chapters zip files)

mienaiyami commented 3 months ago

Load the entire manga folder with all the zip files within

Unzipping is resource heavy process, and if you are unzipping this many files then more so. You could say that it should open the first zip file then. Because of how context menu option works for whole app, its not a great idea to load the entire manga. Context menu option will only load anything as a "Chapter". Note that if you load a chapter, other chapters in same folder will became available in side-list automatically.

yagamiyakumo commented 3 months ago

Load the entire manga folder with all the zip files within

Unzipping is resource heavy process, and if you are unzipping this many files then more so. You could say that it should open the first zip file then. Because of how context menu option works for whole app, its not a great idea to load the entire manga. Context menu option will only load anything as a "Chapter". Note that if you load a chapter, other chapters in same folder will became available in side-list automatically.

Wouldn't opening the folder and loading/extracting only the first/last chapter in the list and the rest of the chapter showing up in the side-list be idea then? I'm almost certain that's how it used to work in an earlier version until the recent update or two.

I'm not requesting for all chapters to be extracted in case there's any misunderstanding. I just want to be able to right click a manga folder and launch it in Yomikiru with either first/last chapter extracted. Kind of like how it would behave if I go inside the manga folder and open any of the chapters (zip file) via context menu, with the rest of the chapters in the manga showing up on the side-list, only extracting that particular chapter if I select it

mienaiyami commented 3 months ago

Wouldn't opening the folder and loading/extracting only the first/last chapter in the list and the rest of the chapter showing up in the side-list be idea then?

It's not hard to make it work, but the "Open in Yomikiru" option is meant to open a chapter. Imagine the case of manga folder with chapter "folders", here I need to check if any folder have "images" in it. And if there was no image found, it will have to go over all folders. It will get out of hand very quicky, in code as well.

If you are telling to make this feature just for archive files, then again it creates an anti-pattern.

I hope you will understand, adding new features is not hard, but just adding anything creates lots of problem. When I had just started working on Yomikiru I did this mistake too often, and now I'm facing many issues trying to maintain and adding important features.

So for now, the "Open in Yomikiru" option is only opening chapters. Might add different option for manga folder later when major issues are fixed.

yagamiyakumo commented 3 months ago

I see. Thank you for your explanation. Here's hoping for the day open for manga folder gets added as well!