mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
217 stars 10 forks source link

Letter and Word Spacing Values #361

Closed omodia closed 2 months ago

omodia commented 2 months ago

Type of installation

Portable (.zip)

Type of reader (if reader related)

epub

Steps to reproduce

  1. Open any epub.
  2. Activate Word Spacing and Letter Spacing.
  3. Change their values.

✔️ Expected Behavior

  1. For the value boxes of letter and word spacing to be changed, ranging from 0 to n.nn.
  2. And the value boxes of letter and word spacing to be more spacious as they would follow two digits after period and their current boxes are not legible.

❌ Actual Behavior

  1. Increasing / decreasing the value causes it to go to minus somehow.
  2. Box are not spacious.

https://github.com/mienaiyami/yomikiru/assets/116664905/9c8b7ab7-0a8d-4713-92a3-97978e4bce81


Somehow its looping.

https://github.com/mienaiyami/yomikiru/assets/116664905/65770d5c-1214-455f-8108-75c95d8a312a

omodia commented 2 months ago

✔️ Expected Behavior

For the value boxes of letter and word spacing to range from 0 to n.nn.

omodia commented 2 months ago

Some suggestions.

  1. Line height,
    • Minimum value = 1.
    • Value Range = 1 to n.
      • Example = 1, 2, n.
    • Increments / Decrements of 1 when using arrows.
    • As 0 means, the lines of the same paragraph would merge forming a single line, making it unreadable.
  2. For Paragraph Spacing,
    • Minimum value = 0.
    • Value Range = 0 to n.
      • Example = 0, 1, 2, n.
    • Increments / Decrements of 1 when using arrows.
  3. For other 2, i.e. Word and Letter Spacing,
    • Minimum value = 0.
    • Value Range = 0 to n.nn.
      • Example = 0, 0.01, 0.02, to n.nn.
    • Increments / Decrements of 0.01 when using arrows.
    • As 0.1 or 1 would be large for word and letter spacing.
  4. Where n = 9 for all 4 epub spacing options (for all cases).
mienaiyami commented 2 months ago

Some suggestions.

  1. Line height,
  • Minimum value = 1.
  • Value Range = 1 to n.
    • Example = 1, 2, n.
  • Increments / Decrements of 1 when using arrows.
  • As 0 means, the lines of the same paragraph would merge forming a single line, making it unreadable.
  1. For Paragraph Spacing,
  • Minimum value = 0.
  • Value Range = 0 to n.
    • Example = 0, 1, 2, n.
  • Increments / Decrements of 1 when using arrows.

When setting the limits initially I did consider this same, but later i had to lower them a bit because it was needed. Increment of 1 is too much in my opinion, after testing and using it for a long time of course.

And in word spacing 0.01 is too small.

omodia commented 2 months ago

I agree with you.

  1. For Paragraph, Line, and Word spacing,
    • Increment / Decrement = 0.1 upto a max of 9.
  2. For Letter Spacing,
    • Increment / Decrement = 0.01 upto a max of 1. (Not 9 for this, but 1).
omodia commented 2 months ago
  1. For Paragraph, Line, and Word spacing,
  • Increment / Decrement = 0.1 upto a max of 9.

Here only for word spacing, the max value = 1 or 2, as this is very large.

omodia commented 2 months ago

Its partially solved.

1. For word and letter spacing only,

2. All 4 layout input boxes still loop.

3. For Letter spacing only,


https://github.com/mienaiyami/yomikiru/assets/116664905/b22ef484-972c-465d-a722-691483d3f427

mienaiyami commented 2 months ago

There have been cases when I needed word and letter spacing in negative, it totally depends on the font you use. While noone will need it as low as -1 but I have kept it there for specific cases.