mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**
MIT License
223 stars 10 forks source link

--topBar-hover-color #46

Closed omodia closed 1 year ago

omodia commented 1 year ago

Steps to reproduce

  1. Go to --topBar-hover-color and pick a color that is different from --body-bg.

✔️ Expected Behavior

Expecting the top bar color to change to chosen color in --topBar-hover-color.

❌ Actual Behavior

Top Bar color is not changing, but the home and settings button background color changed to the selected color.

mienaiyami commented 1 year ago

--topBar-hover-color is color which button change to when mouse is over them, thought this doesnt apply to system button anymore. --topBar-color is what you are looking for.

omodia commented 1 year ago

I get it now. But the name of '--topBar-hover-color' should be '--topBar-Button-hover-color' or something along those lines to avoid confusion.

omodia commented 1 year ago

next release?

mienaiyami commented 1 year ago

Sorry for delaying release, I have been trying to improve performance. Update will be available soon. This issue is hard to fix as it will disrupt custom themes users have made already, But I will try to fix to my best.

omodia commented 1 year ago

Sorry for delaying release, I have been trying to improve performance.

Take your time to improve performance.

omodia commented 1 year ago

This issue is hard to fix as it will disrupt custom themes users have made already, But I will try to fix to my best.

Write something like this in the next release changelog.

Wouldn't it solve the issue?

mienaiyami commented 1 year ago

Sorry, I had already pushed release, but it canceled due to internet issue. You should be able to see it now.

omodia commented 1 year ago

I think you misunderstood my intention, I just suggested a way to fix to the issue and did not ask about the release. Thank you.