Theme Maker Bugs - Githubissues

mienaiyami / yomikiru

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**

MIT License

223 stars 10 forks source link

Theme Maker Bugs #75

Closed omodia closed 1 year ago

omodia commented 1 year ago

Issue

1. --icon-color

'Link' is linked to --font-color instead of --icon-color.
Some fonts are changing when using --icon-color. The fonts should be linked to --font-color.

--icon-color

omodia commented 1 year ago

2. --btn-color1 to --button-color1

Some button colors are not linked to it and are instead lined to --icon-color.

--button-color1

omodia commented 1 year ago

3. --font-color

Many fonts are not linked to it and are instead linked --icon-color.
Reader settings font colors are not being changed.
'search' in list is not changed.
These are linked to --icon-color.

--font-color

omodia commented 1 year ago

4. --color-primary

It is not linked to anything.

5. --color-secondary

This should be linked to the list view's manga and chapter below and above lines too.

--color-secondary

omodia commented 1 year ago

--divider-color
- Collapsible vertical Main divider lines in the home page are not lined to it.

mienaiyami commented 1 year ago

I actually need to redo whole theme system as it wasnt in mind to make it customizable when i started

omodia commented 1 year ago

I actually need to redo whole theme system as it wasnt in mind to make it customizable when i started

Thank you. Looking forward to it.

omodia commented 1 year ago

Some suggestions / requests when redoing the theme system,

Full names without shortcuts. For example, btn-color to Button Colour, body-bg to Body Background, etc.
Clear names. For example, colour-primary, colour-secondary are not simple to understand.
Whereas Divider-Colour, Font-Colour are simple to understand and clear names.