search

miensol / SimpleConfigSections

An attempt to make defining .net configuration sections a bit simpler
9 stars 5 forks source link

INamingConvention.AttributeName addition allowing customization of a configuration element's attribute naming. #1

Closed pruiz closed 8 years ago

pruiz commented 8 years ago

Added a new AttributeName method to INamingConventions allowing finer control over configuration element's attributes, along with handling of Sys.ComponentModel.DefaultValueAttribute

miensol commented 8 years ago

Seems like a nice addition, thanks.

Will try to merge it soon.

pruiz commented 8 years ago

Sure, just let me know wether I can help somehow. ;)

pruiz commented 8 years ago

@miensol Hi, did you had a chance on reviewing this?

pruiz commented 8 years ago

Hi,

Oops, I missed that one.. I've commited a fix for this using legacy GetCustomAttribute(Type) instead, as upgrading the solution to another .net fx version seemed a task for an independent pull request.

Regards

pruiz commented 8 years ago

@miensol May I do anything else in order to get this merged? ;)

pruiz commented 8 years ago

Ok, this time I've ensured this builds on net3.5.. ;)

miensol commented 8 years ago

Thanks for the changes :+1: And sorry it took so long, it's been a while since I've used Windows :)

I've also pushed an update with version 1.2.0 to nuget.