mierak / rmpc

A configurable, terminal based Media Player Client with album art support via various terminal image protocols
https://mierak.github.io/rmpc/
BSD 3-Clause "New" or "Revised" License
138 stars 8 forks source link

Root level of any tab reset current position #116

Closed soifou closed 2 weeks ago

soifou commented 2 weeks ago

Description

I don't know if this is intended but the root level of any tab does not keep the current user position in the list when switching back and forth. Sublevel does (albums of an artist, songs of an album).

The Queue tab behave differently since it will jump to the current playing song, not the first item.

Steps to reproduce

Root level case:

Sublevel case:

Expected behavior

I think the expected behaviour would be to always keep the last position in any tab, no matter what level we are.

In the Queue tab, it needs then to have an action to jump to the current song.

What terminal emulator are you running rmpc in?

No response

rmpc debuginfo

no relevant

Config file

no relevant

Relevant log output

no relevant

mierak commented 2 weeks ago

Yeah I knew about the root level issue and completely forgot. It requires some logic to determine whether its the very first render or not, thanks for reminding me.

For the Queue/Tab pane, fair point, makes more sense to do it as you describe I think.

mierak commented 2 weeks ago

Hopefully solved, the new action is JumpToCurrent in Queue.

Thanks again, you have been a huge help so far!

soifou commented 2 weeks ago

Works like a charm :) well done @mierak you rock!