mieszko4 / react-native-zoom-us

MIT License
123 stars 118 forks source link

Take useful code from https://github.com/mieszko4/react-native-zoom-us/pull/40 #147

Open mieszko4 opened 2 years ago

mieszko4 commented 2 years ago

Go through the last review (https://github.com/mieszko4/react-native-zoom-us/pull/40#pullrequestreview-768727330) and see what could be re-used from that pr

pmogollons commented 2 years ago

Taking a deeper look at this, I propose we implement all listeners and send events to JS with the same name and params that zoom sdk has, for example.

public void onUserVideoStatusChanged(long userId, VideoStatus videoStatus) {
  sendEvent("MeetingEvent", "onUserVideoStatusChanged", {userId, videoStatus});
}

This will give more flexibility to developers to respond to the listeners in their own way, it will also be inline with zoom docs (not the best, but better than nothing).

We will also need to expose more methods to

We will need to check how to parse and send what we can of some params like videoStatus.

@mieszko4 if you support this we can start by planning which other methods we should expose and which helpers to create, here is a list of links we should take a look at.

mieszko4 commented 2 years ago

Because of the ios/android/this lib inconsistencies, if we want to sort out the naming for events I guess we should start with a overview table where we would put all the events per row.

Columns would be:

With this overview we would have a better picture on how to make this naming nice and consistent

Actually a similar table could be done for the exposed methods.

pmogollons commented 2 years ago

Perfect, I created this spreadsheet. Is not yet completed but is a start with some name proposals. Please request access and ill let you in with editor privilege.

https://docs.google.com/spreadsheets/d/108fsKjXnTdXfVxtZZNzksL6WUgDfQifbBYrQpqUHVWk/edit?usp=sharing

mieszko4 commented 2 years ago

@pmogollons this file is not public so I cannot access it. Could you make it at least read-only + allow to comment for everyone?

pmogollons commented 2 years ago

Done, is now read-only with comment permissions for everyone and you have editor access.

mieszko4 commented 2 years ago

@pmogollons :rocket: