search

mieszko4 / react-native-zoom-us

MIT License
126 stars 118 forks source link

```usesCleartextTraffic``` false by default causing issue #195

Closed Jothinayagan closed 2 years ago

Jothinayagan commented 2 years ago

Environment: "react": "17.0.1" "react-native": "0.64.2" "react-native-zoom-us":"^6.6.1"

Error: 
Attribute application@usesCleartextTraffic value=(true) from AndroidManifest.xml:8:9-44
    is also present at [com.github.zoom-us-community.jitpack-zoom-us:mobilertc:5.9.1.3674] AndroidManifest.xml:85:9-45 value=(false).
    Suggestion: add 'tools:replace="android:usesCleartextTraffic"' to <application> element at AndroidManifest.xml:7:5-12:19 to override.

As per Android Developers documentation, it is not good practice to disable the usesCleartextTraffic

https://developer.android.com/guide/topics/manifest/application-element#usesCleartextTraffic

mieszko4 commented 2 years ago

This is requirement of Zoom Us SDK as of v5.9.0 (https://8xmdmkir8ctlkfj8dttx.noticeable.news/publications/android-meeting-sdk-v5-9-0) so we cannot avoid this until they fix it. See our README.md for the steps of what exceptions need to be provided (https://github.com/mieszko4/react-native-zoom-us#android)

Jothinayagan commented 2 years ago

This is requirement of Zoom Us SDK as of v5.9.0 (https://8xmdmkir8ctlkfj8dttx.noticeable.news/publications/android-meeting-sdk-v5-9-0) so we cannot avoid this until they fix it. See our README.md for the steps of what exceptions need to be provided (https://github.com/mieszko4/react-native-zoom-us#android)

README.md steps works. Thanks, @mieszko4