search

mieszko4 / react-native-zoom-us

MIT License
126 stars 118 forks source link

feat: prepapare android for 5.11 #218

Closed mieszko4 closed 2 years ago

mieszko4 commented 2 years ago

ZoomSDK for Android complaints about code not being executed on main thread - this PR makes sure to execute ZoomSDK code on main thread, id adds logs, try/catch, cleans up logic. It also fixes issues with not showing meeting and lost listeners after backgrounding then foregrounding the app. Finally it adds noMeetingErrorMessage to startMeeting params.

Closes https://github.com/mieszko4/react-native-zoom-us/issues/192 Closes https://github.com/mieszko4/react-native-zoom-us/issues/166 Hopefully closes https://github.com/mieszko4/react-native-zoom-us/issues/162

Smoke Test Procedure

The following procedure covers testing of the bridge (initialization and join meeting only).

Android

Emulator

  1. [x] Development: yarn run android

Real Device

  1. [x] Development: yarn run android
  2. [x] Release: cd android && ./gradlew assembleRelease && cd .., adb install android/app/build/outputs/apk/release/app-release.apk

iOS

Simulator

  1. [ ] Development: yarn run ios (Note that M1 chip is not supported by Zoom SDK)

Real Device

Note: You will need to allow to install app; look for: Settings -> General -> Device Management -> Apple Development

  1. [ ] Development: Xcode: Product -> Run
  2. [ ] Release: Xcode: Product -> Profile
  3. [ ] Archive: Xcode: Product -> Archive