mieszko4 / react-native-zoom-us

MIT License
122 stars 116 forks source link

error: package us.zoom.sdk does not exist #258

Closed cloudy-ninja closed 1 year ago

cloudy-ninja commented 1 year ago

I upgraded the version to the latest one 6.16.4 and the iOS is working well, but I'm not able to build the Android part. I just followed the readme including adding both commonlib and mobilertc into the folder of node_modules/react-native-zoom-us. While building the app, I got lots of error related to importing us.zoom.sdk

@mieszko4 could you please let me know what's wrong on my side?

cloudy-ninja commented 1 year ago

Screenshot 2023-02-07 at 16 04 21

cloudy-ninja commented 1 year ago

Screenshot 2023-02-07 at 16 05 02

mieszko4 commented 1 year ago

You need to manually copy .aar files. I was not able to push .aar files to jitpack because of LFS limit reached :( And I did not have time to automate this (I created issue to automate https://github.com/mieszko4/react-native-zoom-us/issues/257)

See https://github.com/mieszko4/react-native-zoom-us#getting-started for instructions how to manually add *.aar files.

cloudy-ninja commented 1 year ago

Hi, @mieszko4 Thanks for your reply and efforts, Yes, I already added these two files to the root of react-native-zoom-us module, see the attached screenshot.

cloudy-ninja commented 1 year ago

Screenshot 2023-02-07 at 18 51 44

cloudy-ninja commented 1 year ago

After adding the *.aar files like this, got the above error. Instead, I added them separately to the folders commonlib and mobilertc inside the android folder. (I don't know I misunderstood the readme file) Then the above issues have been disappeared but got another error.(attached the screenshot)

Thanks for your advice!

cloudy-ninja commented 1 year ago

Screenshot 2023-02-07 at 18 55 33

cloudy-ninja commented 1 year ago

Screenshot 2023-02-07 at 18 33 32

mieszko4 commented 1 year ago

Screenshot 2023-02-07 at 18 55 33

Yes, this is the final state of where these *.aar should be placed to.

The instructions may be confusing - feel free to make a PR to improve them.

I see you added *.aar of the root of react-native-zoom-us. They should be added in the root of your project before installing react-native-zoom-us.

But again, you manage to get this part correctly now.

mieszko4 commented 1 year ago

Screenshot 2023-02-07 at 18 33 32

:thinking: I am not sure what the problem is here. Perhaps some collision with react-native-video...

cloudy-ninja commented 1 year ago

@mieszko4 Thanks for your confirmation, I don't think this specific issue is related to our zoom lib. So I'm gonna close this ticket. Have a good day!