mieszko4 / react-native-zoom-us

MIT License
122 stars 115 forks source link

Doc for local development. #308

Open ajayranga opened 7 months ago

ajayranga commented 7 months ago

Hi @mieszko4 , Could you provide some doc such that we can manually change the SDK versions instead of using cocoapods/jitpack for SDKs? As that will be helpful to a lot of developers.

Satyajeetsinh-9 commented 6 months ago

@ajayhcode did you find how to do so? i am facing an issue while on android if we minimize app it goes directly into picture-in-picture mode and when we try to expand it creates new activity that is blank...

frankie-fk commented 6 months ago

on iOS, I have to publish a Pod of 5.14 to fix a crash issue when joining a webinar.

ajayranga commented 6 months ago

@Satyajeetsinh-9 stucked there

frankie-fk commented 6 months ago

@ajayhcode I believe this is fixed in 5.14 SDK. Please see the changelog here: https://devsupport.zoom.us/hc/en-us/articles/13992442561165-Zoom-Meeting-SDK-Android-5-14-0 Fixed an issue where the video turned off when minimizing the meeting.

Satyajeetsinh-9 commented 6 months ago

did you face the same issue with android for picture in picture mode where after re opening it goes to blank screen? @ajayhcode

frankie-fk commented 6 months ago

I also know that mieszko4 is actively working on upgrading 5.14 on Android but facing a crash when joining a webinar.

Satyajeetsinh-9 commented 6 months ago

@ajayhcode I believe this is fixed in 5.14 SDK. Please see the changelog here: https://devsupport.zoom.us/hc/en-us/articles/13992442561165-Zoom-Meeting-SDK-Android-5-14-0 Fixed an issue where the video turned off when minimizing the meeting.

I am sorry but I am new to react native. but does this fix the issue on android for picture in picture mode when you minimize the app and if expand it , it creates new separate activity... or did you faced that issue as well or is it just me...

Satyajeetsinh-9 commented 6 months ago

@frankie-fk @ajayhcode were you able to update SDK to 5.14 ? i see that in below link https://github.com/zoom-us-community/jitpack-zoom-us there is already defined sdk 5.14.11.14322, but when I tried to replace with that sdk in native modules build.config first I got some errors , after clearing them I was able to run the application but when it ran it started showing error "RNZoomUS native module is not linked" -> my RN version is 0.72

@mieszko4 do you how can we fix this?

mieszko4 commented 3 months ago

Please try with react-native-zoom-us@6.20.0 (it uses 5.14.11.8690) to fix issue with picture-in-picture and perhaps other issues you are having.

I will keep this issue open until we write a doc to change the SDK versions instead of using cocoapods/jitpack. Essentially to do that you need to:

Android

  1. Create a PR for new version for JitPack package - see in https://github.com/zoom-us-community/jitpack-zoom-us
  2. Override version of com.github.zoom-us-community:jitpack-zoom-us in android/build.gradle

iOS

  1. Create a PR for new version of pod - see https://github.com/zoom-us-community/zoom-sdk-pods
  2. Override version of ZoomSDK in RNZoomUs.podspec