search

mifi / cognito-backup

CLI for backing up AWS Cogntito User Pools
MIT License
154 stars 26 forks source link

Add profile flag #8

Closed michael-misshore closed 6 years ago

michael-misshore commented 6 years ago

Addresses #7

mifi commented 6 years ago

Thanks for the PR. I think that it's not really necessary to have such an option,because you can just do AWS_PROFILE=profile cognito-backup ...

I could be open for adding it, however i would like it to be only approx one line of code. Also it sounds a bit scary to override the whole credentials object with a new SharedIniFileCredentials, no?

michael-misshore commented 6 years ago

@mifi Thanks for the recommendation. I didn't even think to try setting the ENV variable inline. I'll close this as the profile flag is now longer necessary, however, might be nice to have consistency with the AWS CLI?