search

mifi / editly

Slick, declarative command line video editing & API
MIT License
4.79k stars 312 forks source link

[Feature Request] text/title.fontSize #107

Open therealadityashankar opened 3 years ago

therealadityashankar commented 3 years ago

currently there is no way to set a font size for text, so that sux I created a wrapper around this project https://github.com/therealadityashankar/codeVideo, and since I wanted that feature I'd to use a canvas to achieve it, it'd be really cool if this feature could be added

Editly is super amazing btw, thank you so much for creating it

seanconrad1 commented 3 years ago

Definitely would be a good feature to have

nabilfreeman commented 3 years ago

I managed to make a custom title using ./sources/fabric/fabricFrameSources.js as inspiration. Started by editing node_modules with patch-package until I was confident with Fabric then easily worked with canvas.

I think having more options on titles would be great, currently a lot of parameters are calculated relative to the video frame dimensions, so it would be quite easily to override those with some params.

tavisca-amitj commented 2 years ago

+1

ecc521 commented 1 year ago

I'm a little stunned this has been open for over 2 years now - there's no reason we should have hardcoded values that can't be changed for title pages, and it looks like a 30 minute fix.

bb2002 commented 1 year ago

I also want to change the fontSize of the type==title, but this feature hasn't been fixed in two years. Eventually, I solved it by modifying the fontSize variable on line 256 of the sources/fabric/fabricFrameSources.js file.

sjc57 commented 1 year ago

This seems like a very useful request. Apparently the pull request above failed because there was a extra space at the end of a comment. Is it possible for somebody to fix this? Thanks.

ecc521 commented 1 year ago

You would be correct that the PR failed strictly for formatting reasons, and could be safely merged. That said, if I remember correctly, I did not implement font size in all the cases where font size might be useful (there are other cases where fonts can be used and font sizes should be configurable), so I don't actually believe merging #250 in it's current state is ideal, as I feel like fontSize should be made standard across the entire library.

You're welcome to clone my repo and use it yourself. That's what I did, so I no longer have any real interest in getting the PR merged