mifi / editly

Slick, declarative command line video editing & API
MIT License
4.8k stars 312 forks source link

rotation can be not only in the first element of side_data_list #264

Open smka opened 1 year ago

smka commented 1 year ago

Hello! I've found that rotation on vertical HDR videos from my phone defined incorrectly. All videos without HDR don't have this issue. image My setup:

ffprobe shows that HDR videos have several elements in side_data_list

{
  "side_data_list":[
    {
      "side_data_type":"DOVI configuration record",
      "dv_version_major":1,
      "dv_version_minor":0,
      "dv_profile":8,
      "dv_level":5,
      "rpu_present_flag":1,
      "el_present_flag":0,
      "bl_present_flag":1,
      "dv_bl_signal_compatibility_id":4
    },
    {
      "side_data_type":"Display Matrix",
      "displaymatrix":"\n00000000:            0       65536           0\n00000001:       -65536           0           0\n00000002:     70778880           0  1073741824\n",
      "rotation":-90
    }
  ]
}

So I replaced this with foreach cycle.

PS. But I still don't understand why parseInt(stream.tags && stream.tags.rotate, 10) always return NaN, when data is present in ffprobe json.