Don't trim filename - Githubissues

mifi / ezshare

Easily share files, folders and clipboard over LAN - Like Google Drive but without internet

MIT License

626 stars 45 forks source link

Closed AlttiRi closed 8 months ago

AlttiRi commented 8 months ago

It trims the filename down to 100 ~bytes~ characters.

UPD:

...while uploading to the server.

mifi commented 8 months ago

are you talking about uploads or downloads?

mifi commented 8 months ago

and how to reproduce exactly?

AlttiRi commented 8 months ago

Upload a file with the follow name:

[example] 123456789—2024.03.14—nikita_varb jessica_rabbit who_framed_roger_rabbit 1girl bare_shoulders between_breasts breasts solo—6ae32b1483fc6621dcbbbdb15144885d.jpg

The result is the uploaded file with

[example] 123456789—2024.03.14—nikita_varb jessica_rabbit who_framed_roger_rabbit 1girl bare_shoulde

filename.

mifi commented 8 months ago

Systems generally allow up to 255 characters, but we default to 100 for usability reasons.

maybe we should increase it to 255, would that be enough?

AlttiRi commented 8 months ago

Yeah.

Also, Node.js internally uses \\?\ prefix, so there is no problem with long path.