mifi / lossless-cut

The swiss army knife of lossless video/audio editing
GNU General Public License v2.0
24.24k stars 1.21k forks source link

Waveform appears seemingly at random #1912

Open xrstf opened 4 months ago

xrstf commented 4 months ago

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Operating System

Windows 10

Steps to reproduce

  1. Open a video file (mkv with x265 in my case)
  2. Click "Show waveform". A bar like this appears as expected:

2024-03-03 09_46_57-New Issue · mifi_lossless-cut — Mozilla Firefox

  1. Zoom in (either via mousewheel or the zoom buttons in the status bar)

Expected behavior

At some zoom level, the audio waveform should appear consistently.

Actual behavior

When zooming in, the bar for the waveform just disappears entirely. I can zoom in and out an in and move back and forth and only when losslesscut feels like it, will it seemingly at random actually show the waveform again.

https://github.com/mifi/lossless-cut/assets/127499/c089dbc0-b77d-4ef4-b0d3-0a8b7b15b730

Is this maybe losslesscut still loading? Or what could be the reason I have to wait / click around randomly? Would there be a chance to include a loading indicator on the waveform bar to let me know that/if something is going to happen?

Sometimes when clicking around, the entire waveform bar just disappears and I get errors like

2024-03-03 09_57_53-LosslessCut - S05E10 - New Ground mkv

but I guess those errors are from me clicking around fast.

Share log from developer tools

No response

mifi commented 4 months ago

i couldn't reproduce it right now, but there could be a bug there yes

xrstf commented 4 months ago

My video files are ~1.5GB per file, stored on an internal HDD. Video is x265 and the audio streams are DTS / Vorbis.

shalex28 commented 2 months ago

Would like to add: There is no waveform shown for my file of around 100MB in TS Format. But waves do appear for this my file exported in MP4 or Matroska.

shalex28 commented 2 months ago

p.s. zooming had no effect

mifi commented 2 months ago

can you try the nightly build? edit: is it possible that your TS file has multiple audio tracks, and waveform is shown for the first track (which might be silent?)

shalex28 commented 2 months ago
  1. no there are only 2 tracks - one for video one for audio tracks
shalex28 commented 2 months ago
  1. yes I tried https://github.com/mifi/lossless-cut/actions/runs/8859012902 and the result was the wave panel without waveform. after
shalex28 commented 2 months ago

before applying the build there was no wave panel at all before

shalex28 commented 2 months ago

I want to thank you anyway for the great software! I finished my small family video with help of it!

mifi commented 2 months ago

alright. probably a bug in ffmpeg. unfortunately i cannot reproduce the problem with a TS file (waveform works for me)