search

mifi / lossless-cut

The swiss army knife of lossless video/audio editing
GNU General Public License v2.0
24.24k stars 1.21k forks source link

Improving fast seek behavior ? #1957

Closed Mrnofish closed 2 months ago

Mrnofish commented 2 months ago

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

Currently losslesscut employs an acceleration technique when a seek button is kept pressed.

This is an exceedingly annoying behavior whenever I'm scanning for specific events in a long video, such as highlights in a match: I need to stop pressing the seek button repeatedly, otherwise the seek point will start skipping forward in bigger increments, jumping over shorter action sequences entirely.

One way to ameloriate this issue would be a way to disable skip acceleration.

Another could be having a way to scan a video automatically at high speed, without having to keep the skip button pressed.

What do you think?

mifi commented 2 months ago

"Timeline keyboard seek acceleration" under settings. (set it to 1)

Mrnofish commented 2 months ago

Sorry, I did look for a preference but obviously I must've missed that slider.

That said, even after disabling acceleration, I'm still forced to release the FFWD button every now and then, otherwise the preview stops updating regularly.

It seems to work fine for a while after the button is first pressed, however, after some time, the jumps become quite big.

This seems to happen mostly with longer videos, roughly 2 hours.

I can fast seek a video with MPC-HC or VLC from a mechanical drive with no issue, but LosslessCut exhibits this problem even when the same file is copied to an SSD.

It gets worse if I increase the keyboard skip value. Setting it to 5 or 10 seconds causes the preview to stop completely after the first frame update.

Dropping it to 0.8 improves the situation.

BTW the sliders are quite inconvenient to operate: the range is very wide compared to its screen representation, making accurate changes is hard.

If I click on the slider handle, I can make exactly one change with the keyboard: subsequent key presses are fed to the main window instead of the slider control.

mifi commented 2 months ago

That said, even after disabling acceleration, I'm still forced to release the FFWD button every now and then, otherwise the preview stops updating regularly.

I believe it's the same as #1881

BTW the sliders are quite inconvenient to operate: the range is very wide compared to its screen representation, making accurate changes is hard.

the next version will include a more precise slider (currently in nightly build) ca7a9d3eebfb990cca2955e20e77739faa9da018

Mrnofish commented 2 months ago

I've subscribed to the other issue and will report there after the changes mentioned here and there have made it to the public.

Thank you for the help!