mifi / lossless-cut

The swiss army knife of lossless video/audio editing
GNU General Public License v2.0
24.01k stars 1.19k forks source link

Improve Dark Mode #1969

Open userzzzq opened 2 months ago

userzzzq commented 2 months ago

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

some UI still use white background, such as the Merge Files page, the scrollbar of "batch files" pannel (at left). please improve the dark mode.

mifi commented 2 months ago

related #733

ac615223s5 commented 2 months ago

also an option to use the system theme

Igetin commented 2 months ago

also an option to use the system theme

Yeah, I would appreciate an option to synchronize the UI to the system theme. For reference, Electron's native-theme API should work fine for this and supports Linux/Windows/macOS.

XCanG commented 1 month ago

@mifi I have a little suggestion: add style color-scheme

You can use color-scheme: light dark; to support both themes, even right now it would improve scroll bars, an example if you add this to html element styles via devtools:

Another screen example:

Additionally there is light-dark() function that will allow you to style freely between both themes, like that:

.selector {
    background-color: light-dark(var(--light-background), var(--dark-background));
    color: light-dark(var(--light-text), var(--dark-text));
}

Currently lossless-cut use Chrome version 118, so it is not supported. image

But if you upgrade Electron with a Chrome version 123 or newer, you can easily use it.

XCanG commented 1 month ago

Well, it is also possible to manually restyle scrollbars with CSS instead of relying on color-scheme like that (Chrome-only):

*::-webkit-scrollbar {
    width: 8px;
    height: 8px;
    background-color: transparent;
}

*::-webkit-scrollbar-thumb {
    background-color: #8888;
}

*::-webkit-scrollbar:hover {
    background-color: #8883;
}
mifi commented 1 month ago

I've now added color-scheme according to the user's dark/light setting in the app