search

mifi / lossless-cut

The swiss army knife of lossless video/audio editing
https://losslesscut.app/
GNU General Public License v2.0
27.98k stars 1.36k forks source link

Excessive flickering when cutting #2083

Closed Tomahawk27x closed 1 month ago

Tomahawk27x commented 3 months ago

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Operating System

Windows 10

Steps to reproduce

Open file, then just seek around.

Expected behavior

Smooth seeking without any blank screens, flickering and stutters

Actual behavior

https://github.com/user-attachments/assets/5367a535-0b4e-4d7d-ba67-6b5b314cc641

This has happened everytime I tried to use the app.

Share log from developer tools

No response

mifi commented 3 months ago

does it happen when you playback also? or just when you seek? does it happen with all files? do you have any other computer to try on?

Tomahawk27x commented 3 months ago

Playback is smooth, just seeking, it does happen with all files, I don't have any other computer, I have an NVIDIA graphics card and I record through shadowplay if that helps with anything.

Tomahawk27x commented 3 months ago

Okay so I actually had some old videos recorded on a craptop with OBS, some flickered some didn't. Different resolutions too, had some clips recorded with Shadowplay on a 4:3 monitor and no signs of flickering, very strange.

Changing the window size of the cutter app fixes it for a moment only until I start seeking again.

mifi commented 3 months ago

some people had trouble with nvidia and losslesscut they changed some settings in the nvidia control panel (for losslesscut), see https://github.com/search?q=repo%3Amifi%2Flossless-cut+nvidia&type=issues

mattack1 commented 3 months ago

I noticed a similar thing, on MacOS.. But I'm usually editing MPEG2 files (SD files downloaded from my Tivo), which LLC doesn't support natively (so I can't actually just play with audio).. but a recent change seems to make it get video frames more quickly (GOOD), but IIRC it always flashes black then shows the video frame.

But it's still faster at showing the frame than it used to be.

Tomahawk27x commented 3 months ago

some people had trouble with nvidia and losslesscut they changed some settings in the nvidia control panel (for losslesscut), see https://github.com/search?q=repo%3Amifi%2Flossless-cut+nvidia&type=issues

I've already tried that and it doesn't make any difference, the only fix I know is turning on compatibility mode for LLC which was mentioned in a previous issue, but seeking isn't as smooth. No flickering, just lower framerates, so I was wondering if there was a nother fix without changing the compatibility.

Tomahawk27x commented 3 months ago

Note that playback isn't an issue at all it goes perfectly normal it's just the seeking.

mifi commented 3 months ago

@Tomahawk27x out of curiosity if you load the same if in google chrome and scrub through, does the same happen?

Tomahawk27x commented 3 months ago

Nope, not at all. Sorry for late reply

mifi commented 3 months ago

it could be a problem with the current version of electron and might get solved when we upgrade

mifi commented 3 months ago

electron has now been upgraded so you could try again with the latest version.

Tomahawk27x commented 3 months ago

Unfortunately, no luck.

Frizzle99 commented 3 months ago

Hello. Not sure what github etiquette is, but I just made an account to say I have this problem as well. It started happening in version 3.61 for me. and is also present in 3.62

mifi commented 3 months ago

@Frizzle99 which OS?

Frizzle99 commented 2 months ago

Windows 11 Pro 23H2. AMD 3700X CPU and 4070 Super graphics card.

mifi commented 2 months ago

does it happen with all kinds of files? what if you try a simple mp4 h264 file like https://github.com/mifi/lossless-cut-fixtures/blob/master/hardangerbrua-dji-phantom.mp4

Frizzle99 commented 2 months ago

Sorry for the late reply. I went back to 3.59.1, Just reinstalled 3.62 and with your file it works fine. Then I tried other files and now they all seem fine too. Not sure what happened there but it seems the problem just solved itself. For me at least, not sure about OP obviously. I'm sorry for wasting your time, Mikael.

Frizzle99 commented 2 months ago

Back again. I failed to see the pattern before but now I noticed the problem is still there. It just -only- happens when the program converts to a supported format. So mostly WMV files and the like, not MKV/MP4

mifi commented 2 months ago

@Frizzle99 I think your problem is different from OP. Maybe you can record a screencast

Frizzle99 commented 2 months ago

Sure. First file is an MP4 source file, working as intended. Second is a wmv file that the app had to convert, showing the black flickering on seeking.

https://github.com/user-attachments/assets/b8b8e24b-85f7-4c9f-85fd-f41327f14577

https://github.com/user-attachments/assets/affd2963-922e-4bfa-b4af-229f9aff1895

Tomahawk27x commented 2 months ago

my files are mp4 yet they still flicker in the cutter

mifi commented 2 months ago

@Frizzle99

WMV.problem.mp4

This is because of ffmpeg assisted playback (see upper left corner): wmv is actually not supported but with the ffmpeg assisted playback it is supported. unfortunately the ffmpeg assisted playback has always been a bit crude and it's not super trivial to make it smoother but I will see if i can get it improved some day.

@Tomahawk27x your issue is a different problem (not ffmpeg-assisted playback) and unfortunately I have no idea what's causing it.

Frizzle99 commented 2 months ago

@Frizzle99

WMV.problem.mp4

This is because of ffmpeg assisted playback (see upper left corner): wmv is actually not supported but with the ffmpeg assisted playback it is supported. unfortunately the ffmpeg assisted playback has always been a bit crude and it's not super trivial to make it smoother but I will see if i can get it improved some day.

I know. It's always been like this with the app but it just started doing the black flicker in the latest version, which is why I added to the conversation here. As it does seem to be a different problem than OP is having I'll say sorry for trying to hijack his thread. ;)

mifi commented 2 months ago

I know. It's always been like this with the app but it just started doing the black flicker in the latest version, which is why I added to the conversation here. As it does seem to be a different problem than OP is having I'll say sorry for trying to hijack his thread. ;)

i did now manage to find a way to reduce this flickering (note again for new readers, it's not the same as OP's flicker)

Kaggypants commented 2 months ago

Having the same issue when trying to cut mp4 and mkv files. Using Windows 11. Most of Lossless' menus look terribly distorted too, as if it's incorrectly trying to scale to a particular resolution.

https://www.youtube.com/watch?v=BJdn-uixKLg

I have tried using different versions of Lossless but, as far back as 3.52.0, they have this issue.

As noted, this is only an issue when using Lossless' video playback. When you make the cut, the export turns out just fine and plays everything without any flickering.

whoiskevinrich commented 1 month ago

[Possible Fix] I have been able to control the flickering behavior by setting the "Multi-Frame Sampled AA (MFAA)" Setting to "Off" for the LosslessCut Application in the NVIDIA Control Panel as shown below.

I'd been having the issue for about a year and figured it was some Nvidia Setting.

image

Tomahawk27x commented 1 month ago

thx it fixed it

mifi commented 1 month ago

Ok closing this as it seems to be an nvidia bug

Kaggypants commented 1 month ago

Just FYI this did not fix it on my end as that setting is globally off in my control panel.

mifi commented 1 month ago

Are you having the problem that Frizzle99 is having or OP’s problem?

Kaggypants commented 1 month ago

Are you having the problem that Frizzle99 is having or OP’s problem?

I'm having the issue mentioned by the OP. You can see it in the video I posted here. I'd like to reemphasize that Lossless' menus look extremely distorted, as if they are displaying at the incorrect resolution. When I click on Lossless after having alt tabbed, the program 'refocuses' and gets rid of the distortion. I believe this is probably causing the flickering issues. As you can see in the attached image, both the menus in the upper left and the buttons in the lower right look distorted/blurry.

blurry

In comparison, here is the refocused version of Lossless:

nonblurry

mifi commented 1 month ago

Do you also have an nvidia gfx card? If so did you try all the nvidia specific workarounds like fps setting etc, from here https://github.com/mifi/lossless-cut/issues/2083#issuecomment-2246150616 ? Also does it happen on other computers or just one one specific computer?

If not nvidia, what kind of graphics card do you have?

this is definitely a bug in the graphics driver, windows, or electron (or a combination of these). Unfortunately there’s no way for me to fix this, and we can only hope it gets fixed in the future by one of these parties, or some people find a workaround.

Kaggypants commented 1 month ago

I've attached my hardware/software specs. Additionally, I am using a GSYNC monitor @ 120FPS.

DxDiag.txt

Here is another video demonstrating the issue:

Example 2

As you can see, when I try to use seeking it will only play for a short amount of time before returning to the beginning of the video and pausing. In the second half of the video, you can see when I try to maximize Lossless and then play the video, the flickering issue is introduced.

I have tried both .mkv and old .mp4 videos that I had no problem cutting in the past using Lossless.

This is really unfortunate since I love your program.

Frizzle99 commented 1 month ago

Okay this is getting out of control a little bit now :D I don't have the same problem as OP, nor Kaggypants from the looks of it. I do also have an nvidia card and a gsync monitor. Turning off gsync or MFAA doesn't help. My issue is just a bit annoying, but it isn't a big deal really. As I said it only happens on videos where the program has to convert the file in order to view or edit it, so it seems to be a problem with the latest version of ffmpeg. Hopefully it will go away with future versions. Thanks for your program Mikael.

Frizzle99 commented 1 month ago

Problem solved on this end with 3.63.0 Best version ever for me. :)

Kaggypants commented 1 month ago

I still have playback flickering in 3.63.0.0. When I try to maximize Lossless, the screen goes black. The UI text is also still distorted.

However, the videos are no longer resetting after 5 seconds when I hit play. Not ideal but serviceable at least.

AwesomeAxolotl commented 2 weeks ago

edit: deactivating fast vsync fixed it for me without needing to deactivate GSYNC.

original: The fixes don't work for me (nvidia settings I found suggested). Is there a good way to disable the html5fied (ffmpeg-assisted) playback or avoid it when switching from one opened file to the next? (the preview works without it)... not only the video flickers but the whole application. I encounter it when I try to switch from one video to the other because that's not possible to do with invoking the playback. Just opening one video and cutting it works without issues because I just have to avoid pressing play. (tested version: 3.63.0.0) Deactivating GSYNC for the application avoids the problem, but then I'll have black screens for a second or two in the situations the error would normally start, so that's not good, either. In those cases it doesn't start to create the html5fied videos for playback because it's naturally supported after all.