Closed lachieh closed 7 months ago
Thanks for the PR. Yes I tihnk you can remove all the yarn-related changed from the pr, as well as the lottie-web version change is package.json because it doesn't do anything. I might have misunderstood but I thought the change was a TS-only fix. Why do we need to expose the animElementRef
? Nobody requested the need for the div element to be exposed as a ref (until now). I'm not sure if we'll want that to be part of the API. What's the use case for it?
Thanks, ditched the yarn changes and element ref changes. I left the function handling in with the existing ref, but can take that out too if preferred.
seems that something broke in the tests
I'll take a look this weekend 👍
Ok, sorted. Tests run successfully after failing locally so should be good for another run.
I've added some basic type information to the makeLottiePlayer.js
file, but I can remove if you'd prefer.
Closes #110
I needed to update the
lottie-web
version to get the correct types, but I don't useyarn
so I installed latest and it looks like it updated the lock file quite significantly. Let me know if this is not good and I'll leave the changes toyarn.lock
off.