search

mifi / react-lottie-player

Fully declarative React Lottie player
MIT License
495 stars 52 forks source link

Add type definitions for LottiePlayerLight #51

Closed mpeyper closed 2 years ago

mpeyper commented 2 years ago

Fixes #45

Adds a type definition for LottiePlayerLight that reexports the index.d.ts types.

~I have also added a /light module to simplify importing the light version and update the example and docs. If you would prefer to leave this out of this PR, let me know and I'll remove it and leave just the type def.~ Removed.

mifi commented 2 years ago

Hi. Thanks for your PR. I think changing the export to /light could be a good idea but it requires a major version bump, and I don't see the importance of releasing a major just for that change, so if you could pull that out into a separate PR that would be great. then I could merge that in the future together with any other breaking changes

mpeyper commented 2 years ago

The old import would still work, it's just introducing a new option and changing the recommendation for how to import it, so I don't think a major would be required.

That said, it's the types I'm after and don't want to delay them so if I'll update the PR in a few hours when I start work if I don't hear back from you before then.

mifi commented 2 years ago

The old import would still work, it's just introducing a new option and changing the recommendation for how to import it, so I don't think a major would be required.

Oh my bad then. Anyways thanks for this, merging.