search

mifi / react-lottie-player

Fully declarative React Lottie player
MIT License
505 stars 53 forks source link

bump: `lottie-web` #59

Closed afonsojramos closed 2 years ago

afonsojramos commented 2 years ago

@mifi

mifi commented 2 years ago

Correct me if I'm wrong but I think your change doesn't effectively do anything? due to caret ^

afonsojramos commented 2 years ago

@mifi it adjusts the new minimum. But additionally, I'd say that the '^' should be removed.

mifi commented 2 years ago

what's the benefit of a higher minimum version? what if some people are running an older version

I'm not sure pinning the version by removing ^ is the right thing to do, as many people like to be able to update their dependencies by running yarn upgrade and similar.

afonsojramos commented 2 years ago

I was getting some errors in typescript due to this dependency, but I'll try to force it using npm 8's dependency forcing.