mifriis
commented
2 years ago @Nicoolai if you are up for it, i think this is a good place to get a review.
- We have the Console Commands and Account/Ledger merged in
- There's a POC on Events built in, although with a dirty but very flexible way of doing DI through a serviceLocator Pattern.
- The SolarSystem was slightly reworked to be able to load from both the save file or the JSON Repo. I removed a few none implemented methods.
- CaptainService is still a big mess, noticably in it's high cyclomatic complexity, but not touched in a major way by this PR either.
- A bit less DDD, but a lot more DI through the use of services. Ship and ShipEngine are (i hope) okay examples of implementing domain knowledge in the class.
- Engine, Ship Mass, Fuel and lots of Math implemented to allow for "RealScienceTM" travel around the solar system.
- GameTime is now a service and able to be injected into other services that need it.
- UnitTests and IntegrationLike tests are implemented. Services are pretty much covered 100% while Commands and Events are a bit less (but also a lot closer to the UI, so faking the console is needed).
I would love to get your feedback! I think with these basics in place it will be possible to create other systems like commodities/trade, mining, ship upgrades, crew or even story/tutorial missions.
github-actions[bot]
DOTNET SIIIIX!
Based on VisualBeans command setup i have refactored much of the current code to completely use dependency injection (with only few exceptions)
GameTime still exists and is a Static, it can be tested though since it must be "set" on load and gamestartSolarSystem has been rewritten a bit, it's now designed to work with JSON serialization now.
Events are introduced! When you set a course in your ship an event is added to the GameEvents list marking your date of arrival. On load all events are evaluated and executed if they "happened" while you were away.
SaveFileintroduced as a domain object. The noble goal of making a root aggregate hasn't worked. This way we can control exactly what is saved, how and where to put it back on load.