Peer-to-peer Code Review - Githubissues

miftah1991 / ToDoList

This is simple To-Do App for managing the daily tasks and to keep track on tasks during the day.

https://miftah1991.github.io/ToDoList/dist/

MIT License

17 stars 0 forks source link

Peer-to-peer Code Review #7

Open mengiefen opened 2 years ago

mengiefen commented 2 years ago

Dear @miftah1991,

You have done great! Congratulations 💯 💥**

your code is clean and readable.
your code is working smoothly with all functionalities.
you took an effort to make your code modular.

Ont this section of your code, the two lines code are working a lot of tasks. This might be a performance issue if the number of DOM elements are too many. What do you think if you use appendChild() to add element at the end. https://github.com/miftah1991/ToDoList/blob/6d838e5772d1707597364297735ab7003c6950e0/src/addTask.js#L17-L18

omar25ahmed commented 2 years ago

You have implemented very nice work:

Positive aspects:

your code is very neat
All the features are working great Aspects to improve: After editing a task it became a blank text and it add new task