migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.
GNU General Public License v3.0
64 stars 24 forks source link

追い返されちゃった fails to be de-conjugated. #31

Closed KieranBrannigan closed 3 years ago

KieranBrannigan commented 4 years ago

Type:

Environment:

I'm going to open a PR to resolve the issue:

Description: As outlined by @ Jiro 3000 on the #ideas-discussion channel of the MIA discord (11/5/2020), the MIA dictionary fails to conjugate words such as 追い返されちゃった。I figured this is because the conjugation only goes one deinflection deep, but this word in fact needs 3 deinflections. I have written code so that it will now continue to run the deinflection loop until no more deinflections are found. This solves the aforementioned problem, verified manually with the standard japanese conjugations.json file running current dev cycle add-on on windows 10.