search

migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.
GNU General Public License v3.0
64 stars 24 forks source link

Sanseido web dictionary support #34

Closed MinmoTech closed 3 years ago

MinmoTech commented 4 years ago

Type:

I'm going to open a PR to resolve the issue:

Description: The sanseido web dictionary is a monolingual japanese web dictionary.

It provides concise definitions of words and seems to be useful for the monolingual transition, as can be seen in this video.

After some short testing it's results can be accessed with simple http requests (I tested it with curl). I think it could be implemented in the MIA-Dictionary-Addon in a similar way to the google photos feature.

Would you accept a pull request if I would implement this?

LucasMIA commented 4 years ago

I can't guarantee when I will have time to review and merge the pull request but we would definitely take a look at it at some point if you were to open a pr. 👍

MinmoTech commented 3 years ago

I have only done some stuff for the integration until now, the code itself is simple, but as I have problems navigating the migaku dictionary codebase, I haven't finished it yet.

I have written this simple python script that takes a word as stdin and prints the definition to stdout which I'm using as a quick replacement right now, I hope someone will find it useful until I finish a proper integration: Link to python script

MinmoTech commented 3 years ago

As the sanseido website does not exist anymore, we can close this issue