search

migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.
GNU General Public License v3.0
64 stars 24 forks source link

Card Exporter: (Ctrl + Shift + v) shortcut not being recognized by captureKey@main.py #41

Closed marcuscastelo closed 3 years ago

marcuscastelo commented 4 years ago

Type:

Environment:

I'm going to open a PR to resolve the issue:

Description: Symptom: unable to paste image and/or audio to CardExporter Problem: in my environment, pressing Ctrl + Shift + v doesn't trigger captureKey's elif @main.py Solution: change shotcut to Ctrl + Shift + V (caps V)

It' a really trivial bug, literally one line to fix it.

https://github.com/mass-immersion-approach/MIA-Dictionary-Addon/blob/48c2aebeb0e42dd36414ebb911c3c0cf83916f5a/src/main.py#L470

My particular solution:

elif 'Key.ctrl' in mw.currentlyPressed and 'Key.shift' in mw.currentlyPressed and ("'V'" in mw.currentlyPressed or "'v'" in mw.currentlyPressed):

I've left both 'V' and 'v' in my setup since I thought it was capitalized because of shift modifier, but testing with caps on doesn't seem to change anything, it stays 'V'. But i left it anyway since other systems may have the lowercase 'v'. Uppercase and lowercase behavior

KieranBrannigan commented 3 years ago

Thank you for supporting Migaku.

We have closed this issue since this it is >6 months old; if you feel that this issue is still a problem in the latest version, please comment below and we will reopen and begin investigating this issue.

We apologise that recently we didn't have the manpower to maintain these repos properly, but we aim to maintain them better from here on out.