search

migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.
GNU General Public License v3.0
64 stars 24 forks source link

Support for more media containers than just png or mp3 #43

Open edulim opened 4 years ago

edulim commented 4 years ago

Type:

Environment:

I'm going to open a PR to resolve the issue:

Description: The addon Card Exporter currently only works with mp3 and png. Also, there are some unused imports in the files that make up the project.

I'm going to open a Pull Request that removes some of the major unused imports and adds support for the following audio containers: wav, mp3, ogg, flac, mp4, swf, mov, mpeg, mkv, m4a, 3gp, spx, oga, webm, mpg, ogx, avi, flv and ogv.

As well as to the following image formats: jpg, jpeg, png, tif, tiff, gif, svg and webp.

Those formats are supported by anki, according to its source code.

Ceynou commented 3 years ago

If ogg containers implies opus codec, that would be great.

autoditactics commented 3 years ago

Quicktime only records in m4a and aifc, so this will be great for Mac users.