search

migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.
GNU General Public License v3.0
64 stars 24 forks source link

Searching using Cyrillic characters for Russian appears to be case-sensitive #47

Closed Adaminius closed 3 years ago

Adaminius commented 3 years ago

Type:

Environment:

I'm going to open a PR to resolve the issue:

Description: Searching using the Russian-English dictionary (which uses Cyrillic characters) returns no results if the query is capitalized.

Adaminius commented 3 years ago

Also, the included dictionary seems to have the "ё"s as "е". Writing "ё" this way is common in conversational text because it's a rarer letter, but it makes it impossible to look up words with that letter in them when they are spelled properly. I think the best solution would be to run a second search with "е" substituted for "ё" and to use a dictionary with the correct spelling of words. Someone who's never seen the word before will not know if a "е" is supposed to be a "ё", and they are pronounced completely differently.

KieranBrannigan commented 3 years ago

Thank you for supporting Migaku.

We have closed this issue since this it is >6 months old; if you feel that this issue is still a problem in the latest version, please comment below and we will reopen and begin investigating this issue.

We apologise that recently we didn't have the manpower to maintain these repos properly, but we aim to maintain them better from here on out.