MacOS dark mode search box is dark gray with black text - Githubissues

migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.

GNU General Public License v3.0

64 stars 24 forks source link

MacOS dark mode search box is dark gray with black text #61

Open bookcasey opened 3 years ago

bookcasey commented 3 years ago

Type:

[x] bug
[ ] feature
[ ] enhancement
[ ] question

Environment:

OS: MacOS

I'm going to open a PR to resolve the issue:

[x] yes
[ ] no

Description: Dictionary search input on dark/night mode on MacOS has black text over a dark gray background, which is very hard to see.

Screen Shot 2021-03-06 at 12 32 36 AM

bookcasey commented 3 years ago

The proposed change results in much higher contrast.

Screen Shot 2021-03-06 at 12 40 52 AM

bookcasey commented 3 years ago

Also, the black text seems like a mistake because (at least looking at the code) it seems like it would be white on Windows.

https://github.com/migaku-official/Migaku-Dictionary-Addon/blob/640c136d2f4d11d8e6ad48775e0a8046855055fb/src/midict.py#L1394