migaku-official / Migaku-Dictionary-Addon

Migaku Dictionary allows users to lookup word definitions, export definitions to their cards in real-time, hear word audio and see word frequency, etc. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.
GNU General Public License v3.0
64 stars 24 forks source link

Images from Google may get imported with characters not supported on Android #63

Open kmicklas opened 3 years ago

kmicklas commented 3 years ago

Type:

Environment:

I'm going to open a PR to resolve the issue:

Description: Android storage may use filesystems like FAT which don't support all characters supported in Unix filenames. When syncing to AnkiDroid media with these characters will get dropped. I frequently seem to run into this with images with * in the original URL. The importer should strip these characters so the images will correctly appear on AnkiDroid.

kmicklas commented 3 years ago

I cannot open a PR to fix this until #64 is fixed.

kmicklas commented 3 years ago

As a mitigation I've discovered that Anki's "verify media" feature will rename files with weird characters. Still, it would be nice if Migaku Dictionary would do this automatically.