migaku-official / migaku-browser-extension-issue-tracker

An issue tracker for bugs and other issues related to the Migaku browser extension.
2 stars 0 forks source link

Exporting 195 unique 1T cards resulted in no sound and no image #13

Open heberleh opened 2 years ago

heberleh commented 2 years ago

Describe the bug Exporting cards resulted in no sound and black image. Mp3 and PNG files were generated like I show in the print screen.

To Reproduce

  1. Open a Film
  2. Parse in German
  3. Export Unique 1T cards (195 in my case)
  4. Cards are not correct: files generated have no information encoded in them (no audio, blank image).

Expected behavior Cards with correct audio and images. If not possible, then, error message, canceling the process and avoiding processing all the cards right in the beginning.

Screenshots

migaku-bug-exporting-with-no-sound-no-image migaku-bug-exporting-with-no-sound-no-image_files

Desktop:

Context After started, it asked if I wanted to mute, I clicked No. I could hear the audio being played. I may have switched to another tab and then back to the film. Then the entire time the film was open and visible and the audio audible. No error messages were printed.

heberleh commented 2 years ago

Tested in another computer (Windows 11, same extension version, same Known word lists, frequency list and dictionaries) and it was better, here are the differences:

  1. 65 unique 1T cards instead of 195; the differences may be connected to problems in the parser? In both cases, I had the same sets of Known words and I pressed Sync (though it is not clear why this Sync button is there and what it does). May be connected to #10.
  2. Most of the 65 cards have images, 1 (or more) had black image.
  3. All audio was not sync with subtitle. I tried to set Start Time Padding to 50ms and the End Time Padding to 3000ms. It didn't help. So, the tool is for now not useful. I tried this part many times in different setups, computers, shows, unsuccessfully. See #11 for extra info, before it felt as if it was taking the audio from the card before instead of the current. For the show from this issue, the settings of the extension was set to Play Mode: default, Skip mode: don't skip.

Suggestion for future feature:

  1. Identify is audio.mp3 has no audio (histogram of frequency is not diverse) and remove it automatically before saving the card.
  2. Identify if the image is blank (histogram of colors is not diverse) and remove it before saving the card.