migaku-official / migaku-browser-extension-issue-tracker

An issue tracker for bugs and other issues related to the Migaku browser extension.
2 stars 0 forks source link

Migaku Cantonese Parsing Bug #20

Open ChrisJWest opened 2 years ago

ChrisJWest commented 2 years ago

Describe the bug Word updates are frequently not persisted when marked as learning or known. For example: watching 1T caption on youtube, mark the unknown word as known; the next caption comes up and the word is back to being unknown. The issue is also present in the reader but seems less pronounced (only happens a fraction of the time, compared to almost all the time in the player). The issue only presents itself when we either move to the next caption (player) or move to the next page (reader). Only seems present in Cantonese.

To Reproduce Steps to reproduce the behavior: Player:

  1. Open up Cantonese video with Migaku parser
  2. Update word status of the unknown word(s)
  3. Move forward to future captions
  4. If the same word is there, it is likely reset as unknown.

Reader:

  1. Read a Cantonese text with Migaku reader
  2. Update word statuses on page
  3. Turn over to the next page
  4. If your word is there, there is a chance it was not updated.
  5. Also, upon refresh of the reader, you can return to the original page and none of the word changes from that page have persisted.

Expected behavior Memory of word as being "learning" or "known" should persist.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here. Sending any error messages you receive might help.

I also study Mandarin which uses almost the same parser/dictionary logic and it seems to not have this problem. There is likely a subtle bug somewhere.

ChrisJWest commented 2 years ago

May or may not be related, but another user messaged me that a similar issue is happening in the Spanish Parser:

"that issue with it not marking words as known is happening to me in the reader for Spanish. It seems save the first word I marked as known on a page, but none after that. you can tell it's happening if you look at the word count in toolbar when you mark it as known, it doesn't increment it"