migaku-official / migaku-browser-extension-issue-tracker

An issue tracker for bugs and other issues related to the Migaku browser extension.
2 stars 0 forks source link

Can't enter full screen on YouTube #48

Open nadavspi opened 1 year ago

nadavspi commented 1 year ago

Describe the bug While logged in to my Google account (which has an active YouTube subscription), clicking the full screen button on a YouTube video or hitting f doesn't enter full screen and Migaku JS throws an error.

To Reproduce Steps to reproduce the behavior:

  1. Go to YouTube video while logged in to an account
  2. Click the video full screen button

Expected behavior It should enter full screen

Screenshots

bug

Desktop (please complete the following information):

Additional context

Uncaught TypeError: Cannot read properties of null (reading 'classList')
    at mf.toggleFullScreen (<anonymous>:2:345073)
MinmoTech commented 1 year ago

Further information on this:

when migaku is enabled in the browser, youtube videos can't be fullscreened disable the extension, reload the page, they can be played fullscreen again re-enable the extension, reload the page, they can't be played fullscreen when the extension is enabled, trying to go fullscreen makes it go into theater mode which would make sense if the subs browser was on... but it isn't

Source: https://discord.com/channels/752293144917180496/955592781961769070/1117490185458962463