search

migamake / json-autotype

Automatic Haskell type inference from JSON input
149 stars 23 forks source link

Make running compilation test more robust... #22

Open mgajda opened 6 years ago

mgajda commented 6 years ago

json-autotype currently compiles the generated Haskell code immediately after producing it, in order to verify that it indeed can parse all the input files.

We can either bank on the solution that disables this type of testing (which is not the best practice), or fix these weird environments that fail to run it properly.

Currently it fails on:

patches-accepted

workshub[bot] commented 5 years ago

This issue is now published on WorksHub. If you would like to work on this issue you can start work on the WorksHub Issue Details page.

workshub[bot] commented 4 years ago

A user started working on this issue via WorksHub.

sigrlami commented 4 years ago

@mgajda I think this type of testing should be optional. As generated files in 90% of cases are ADT inside the business application which forces recompilation anyway. But for CI it should be enabled. Thoughts?

mgajda commented 4 years ago

We can improve error message to make it clear that it may be pure compilation setup flaw.

However, we get more bug reports thanks to this features, which improves the code quality here.

mgajda commented 4 years ago

We discussed it within xml-typelift project, and we want to make it shared library to make it easier to test freshly generated code.