migfoo02 / pe

0 stars 0 forks source link

Phone number restriction too restrictive #1

Open migfoo02 opened 12 months ago

migfoo02 commented 12 months ago

Screenshot 2023-11-17 at 4.20.08 PM.png

The phone number must be 8-digit requirement is too restrictive. Given that the app is meant for volunteers anywhere (not just in Singapore), the app should account for varying phone number lengths, as found in other countries.

nus-pe-bot commented 11 months ago

Team's Response

valid issue, duplicate of #5669

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone number only allows for 8 digits, but UG does not specify the target consumers to be from countries with 8-digit phone number.

In the app, phone number is required to be an 8-digit phone number. However, the UG does not specify that this is only for Singaporean users or for countries whose phone numbers are 8 digits.

Hence, this bug does not take into account for phone numbers of various other lengths. This means this app is almost unusable for various countries such as Indonesia, which requires 11 digits (unless they somehow has another phone number with 8 digits, which the localities doesn't sell)

command entered: vedit 9 p/131313131

error message:

Phone numbers should only contain numbers, and it must be 8 digits long

photo of volunteer list:

image.png


[original: nus-cs2103-AY2324S1/pe-interim#5454] [original labels: type.FeatureFlaw severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We did assume that a vast majority of the volunteers in volunteer organisations are likely to be Singaporean, so the chances of having an overseas volunteer is quite rare. However, we did not specify this in the UG so this is a valid issue.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]