soc-se-bot
commented
11 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Name is not able to support additional words such as s/o
The vcreate implementation uses the prefix s/ to indicate a skill. However, people whose names contain s/o cannot possibly indicate their full legal name. Furthermore, your planned enhancements in DG only takes account of special characters such as periods and commas and label slash symbol as an exception, but does not consider the fact that the suffix s/ for skill can be changed to accommodate for the s/o word in names.
command executed:
vcreate n/Frank s/o Harvey p/12345677 e/frankharvey@gmail.comResulting message:
New volunteer added: Frank Phone: 12345677 Email: frankharvey@gmail.com Skills: o Harvey Assigned Events:Person on the list:
specified planned enhancements in DG:
[original: nus-cs2103-AY2324S1/pe-interim#5452] [original labels: type.FeatureFlaw severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Unfortunately, this would also lead to more pain when dealing with other names with slashes (
s/o,d/o, etc.) since we need to make sure that the command format has to change for every possibility. It is easier for us to just restrict slashes in names to mitigate bugs caused by this possibility.Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** It is always possible to indicate that phrases enclosed within quotation marks e.g. "s/o" should be treated as a string instead of a command. It is not fair to ignore this issue for volunteers with slashes in their name as it is important to have a record of their name as shown in their NRIC.
Executing the command vcreate n/Adam s/o Adam p/91234567 e/john123@gmail.com returns an entry with the name Adam and skill o Adam.
This is quite problematic as the abbreviation s/o or d/o is commonly used to denote 'son of' or 'daughter of', and this bug will make it impossible for people with these abbreviations to key in their name correctly. It is unfortunate that the s/ command causes this issue.