mighty-gerbils / gerbil

Gerbil Scheme
https://cons.io
GNU Lesser General Public License v2.1
1.15k stars 110 forks source link

Adds basic AWS S3 client #1019

Closed chiefnoah closed 10 months ago

chiefnoah commented 10 months ago

Includes support for:

Partially resolves #840

netlify[bot] commented 10 months ago

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
Latest commit aacba256c416573b2c5657d64f785b030c2ee9c4
Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/653ec9635f7d260008c1171b
Deploy Preview https://deploy-preview-1019--elastic-ritchie-8f47f9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chiefnoah commented 10 months ago

This is definitely incomplete. I have not even given it a once over myself, so expect there to be silly mistakes 🙂

fare commented 10 months ago

Looks generally good. I'll let vyzo decide whether we want that in gerbil itself, or in a separate pkg gerbil-aws or such. Since it's a proprietary service, I'd lean towards making it a separate package, myself.

vyzo commented 10 months ago

If not in stdlib, this desrves to be a mighty gerbils official package.

Let's get it reviewed here and we decide.

chiefnoah commented 10 months ago

Looks generally good. I'll let vyzo decide whether we want that in gerbil itself, or in a separate pkg gerbil-aws or such. Since it's a proprietary service, I'd lean towards making it a separate package, myself.

This is already in a separate repo under chifnoah/gerbil-s3, I'd be happy to clean that up and transfer ownership to the might-gerbils organization. That being said, while S3 is a proprietary service, the S3 api is definitely a de-facto standard by this point with several open source and 3rd party proprietary implementations. I think I still lean towards having it be in a separate package though.

vyzo commented 10 months ago

Don't worry about the gambit master CI failure, there has been a change in the locat constructor, I'll fix that.

chiefnoah commented 10 months ago

Alright, I think it's good to go now 🙂

chiefnoah commented 10 months ago

Yup! Will work on that