mighty-gerbils / gerbil

Gerbil Scheme
https://cons.io
GNU Lesser General Public License v2.1
1.14k stars 112 forks source link

Rename, test, fix, and document the LL(1) parser combinator library #1063

Closed fare closed 7 months ago

fare commented 7 months ago

std/text/basic-parsers => std/parser/ll1

netlify[bot] commented 7 months ago

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
Latest commit 3100374830ee93172cf4b23e276ad8ba7b785f87
Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/656d38898b28cd0008ea98d3
Deploy Preview https://deploy-preview-1063--elastic-ritchie-8f47f9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fare commented 7 months ago

Requesting technical review from @drewc and overall module naming review from @vyzo

vyzo commented 7 months ago

also, lets not repeat the word parser, so std/parser/basic?

fare commented 7 months ago

I admit I don't understand what move exactly you want and what it has to do with lang. Call?

For the immediate renameโ€”I will rename to just std/parser/ll1. This part I got.

fare commented 7 months ago

It finally passes tests, after all the renaming and API shuffling.